Unverified Commit 39e4e857 authored by Casey's avatar Casey Committed by GitHub

Merge pull request #886 from heroku/we-are-the-walrus

We Are The Walrus (Python 3.8 Support)
parents 6bf3a75d 0207d8af
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
# Master # Master
- Add support for Python 3.8 branch
- Sqlite3 Update: - Sqlite3 Update:
- Add Tests - Add Tests
- Test for Pysqlite - Test for Pysqlite
......
...@@ -52,6 +52,7 @@ export VENDOR_URL ...@@ -52,6 +52,7 @@ export VENDOR_URL
source "$BIN_DIR/default_pythons" source "$BIN_DIR/default_pythons"
# Supported Python Branches # Supported Python Branches
PY38="python-3.8"
PY37="python-3.7" PY37="python-3.7"
PY36="python-3.6" PY36="python-3.6"
PY35="python-3.5" PY35="python-3.5"
......
#!/usr/bin/env bash #!/usr/bin/env bash
DEFAULT_PYTHON_VERSION="python-3.6.9" DEFAULT_PYTHON_VERSION="python-3.6.9"
LATEST_38="python-3.8.0"
LATEST_37="python-3.7.5"
LATEST_36="python-3.6.9" LATEST_36="python-3.6.9"
LATEST_37="python-3.7.4"
LATEST_35="python-3.5.7" LATEST_35="python-3.5.7"
LATEST_34="python-3.4.10" LATEST_34="python-3.4.10"
LATEST_27="python-2.7.16" LATEST_27="python-2.7.16"
export DEFAULT_PYTHON_VERSION LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27 export DEFAULT_PYTHON_VERSION LATEST_38 LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27
...@@ -11,6 +11,13 @@ SECURITY_UPDATE="Python has released a security update! Please consider upgradin ...@@ -11,6 +11,13 @@ SECURITY_UPDATE="Python has released a security update! Please consider upgradin
# check if runtime exists # check if runtime exists
if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
if [[ "$PYTHON_VERSION" == $PY38* ]]; then
# do things to alert the user of security release available
if [ "$PYTHON_VERSION" != "$LATEST_38" ]; then
puts-warn "$SECURITY_UPDATE" "$LATEST_38"
echo " Learn More: https://devcenter.heroku.com/articles/python-runtimes"
fi
fi
if [[ "$PYTHON_VERSION" == $PY37* ]]; then if [[ "$PYTHON_VERSION" == $PY37* ]]; then
# do things to alert the user of security release available # do things to alert the user of security release available
if [ "$PYTHON_VERSION" != "$LATEST_37" ]; then if [ "$PYTHON_VERSION" != "$LATEST_37" ]; then
......
...@@ -146,6 +146,25 @@ testPython3_7_fail() { ...@@ -146,6 +146,25 @@ testPython3_7_fail() {
assertCapturedError assertCapturedError
} }
testPython3_8() {
updateVersion "python3_8" $LATEST_38
compile "python3_8"
if [[ $STACK = "cedar-14" ]]; then
assertCapturedError
else
assertNotCaptured "security update"
assertCaptured $LATEST_38
assertCaptured "Installing SQLite3"
assertCapturedSuccess
fi
}
testPython3_8_fail() {
compile "python3_8_fail"
assertCaptured "Aborting"
assertCapturedError
}
pushd $(dirname 0) >/dev/null pushd $(dirname 0) >/dev/null
popd >/dev/null popd >/dev/null
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment